Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pebble to replace ethdb/pebble #233

Merged
merged 8 commits into from
Dec 2, 2024
Merged

use pebble to replace ethdb/pebble #233

merged 8 commits into from
Dec 2, 2024

Conversation

fearlessfe
Copy link

GrapeBaBa
GrapeBaBa reviewed Nov 28, 2024
View reviewed changes
portalnetwork/storage/ethpepple/storage_test.go
}
radius := db.Radius()
data, err := radius.MarshalSSZ()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where test storage size really pruned?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after every, it will check the size. if size > capacity, prune will be call

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you assert

@GrapeBaBa GrapeBaBa merged commit 1ac486b into optimism-java:gethintegration Dec 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrapeBaBa GrapeBaBa GrapeBaBa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fearlessfe @GrapeBaBa