Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #387: Clean up backend type annotations page. #419

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Nov 19, 2024

This fixes https://github.com/oppia/oppia-web-developer-docs//issues/387 by removing info on the wiki page related to the no-longer-existent mypy denylist.

Copy link
Member

@Ash-2k3 Ash-2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanlip. Just one thought - Should we also mention the limitation of the mypy and when it might not work as expected ?

Something like - "mypy is a static type checker for Python, designed to enforce type safety by verifying that types declared in type annotations are respected throughout the code. However, mypy has limitations when dynamic typing is involved, especially with the use of functions like setattr that dynamically set attributes at runtime."

@seanlip
Copy link
Member Author

seanlip commented Nov 19, 2024

@Ash-2k3 Hm, I think not. Outside tests, we only use setattr in two places and I don't think we should normalize it. If anything I think we should get rid of the usage of setattr.

@Ash-2k3
Copy link
Member

Ash-2k3 commented Nov 19, 2024

Okay, in that case, let's file a bug to drop the usage of setattr, as discussed in our Google Chat conversation.

@seanlip
Copy link
Member Author

seanlip commented Nov 19, 2024

@Ash-2k3 Done -- oppia/oppia#21293.

Copy link
Member

@Ash-2k3 Ash-2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@Ash-2k3 Ash-2k3 merged commit 1c02697 into develop Nov 19, 2024
3 checks passed
@seanlip seanlip deleted the fix-387 branch November 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants