Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installation guide for Docker setup #318

Merged
merged 2 commits into from
May 1, 2024

Conversation

jayam04
Copy link
Collaborator

@jayam04 jayam04 commented Apr 30, 2024

No description provided.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jayam04 -- looks good, just one suggested change, thanks!

@@ -17,19 +17,23 @@ following:

If you need to learn or brush up on these, please do so before trying to start the installation so you don't get confused by our instructions.

## Standard installation using Python setup
## Python setup (soon to be depreciated)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jayam04 -- can we put this section below the Docker one please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@jayam04
Copy link
Collaborator Author

jayam04 commented May 1, 2024

@seanlip moved python setup below docker, PTAL!

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@seanlip seanlip merged commit af57b2f into oppia:develop May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants