Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General updates to various wiki pages based on issues noted over the past few months. #298

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Mar 30, 2024

Summary of fixes:

  • Deprioritize oppia-dev@ in favour of GitHub Discussions
  • Add a suggestion to include debugging info with Beam jobs
  • Ask new contributors to focus only on "Impact: High/Medium" issues, and to avoid "triage needed" issues.
  • Move developer workflow team to the top of the list of teams, since the other teams tend to have more applicants
  • Ask new contributors to actively work to get their PRs in once they're assigned. Add advice about writing a debugging doc.
  • Add more information about how to use debugging docs.
  • Ask contributors to file a flake report if they encounter a flake, and to link to it if requesting a restart.
  • Modify the "launch new feature" instructions to ask contributors to fill out the form when their PR is close to being merged, instead of after it's merged; this is based on discussion with the server admins who would appreciate a heads-up.
  • Ask contributors to verify the changes in the "Files Changed" tab before requesting review.
  • Clean up the sidebar a bit.

@seanlip seanlip changed the title Make general updates to various pages on the wiki based on things noted over the past few months. Make general updates to various pages on the wiki based on issues noted over the past few months. Mar 30, 2024
@seanlip seanlip changed the title Make general updates to various pages on the wiki based on issues noted over the past few months. General updates to various wiki pages based on issues noted over the past few months. Mar 30, 2024
Make-a-pull-request.md Outdated Show resolved Hide resolved
_Sidebar.md Show resolved Hide resolved
@U8NWXD U8NWXD assigned seanlip and unassigned U8NWXD Mar 31, 2024
Copy link
Member

@Ash-2k3 Ash-2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanlip, left some comments, PTAL.

@seanlip seanlip assigned U8NWXD and unassigned seanlip and JayVivarekar Mar 31, 2024
@seanlip
Copy link
Member Author

seanlip commented Mar 31, 2024

@U8NWXD @Ash-2k3 PTAL, I made edits. Thanks!

Contributing-code-to-Oppia.md Show resolved Hide resolved
Contributing-code-to-Oppia.md Show resolved Hide resolved
Copy link
Member

@Ash-2k3 Ash-2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean, just one more comment from me.

Launching-new-features.md Outdated Show resolved Hide resolved
@Ash-2k3 Ash-2k3 assigned seanlip and unassigned Ash-2k3 Mar 31, 2024
@seanlip seanlip assigned Ash-2k3 and unassigned seanlip Apr 1, 2024
@seanlip
Copy link
Member Author

seanlip commented Apr 1, 2024

Thanks @Ash-2k3 -- replied.

Copy link
Member

@Ash-2k3 Ash-2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! @seanlip

Make-a-pull-request.md Outdated Show resolved Hide resolved
@U8NWXD U8NWXD assigned seanlip and unassigned U8NWXD Apr 1, 2024
@Ash-2k3 Ash-2k3 removed their assignment Apr 1, 2024
@seanlip seanlip assigned U8NWXD and unassigned seanlip Apr 1, 2024
@U8NWXD U8NWXD assigned seanlip and unassigned U8NWXD Apr 2, 2024
@seanlip seanlip merged commit 73e6084 into develop Apr 2, 2024
3 checks passed
@seanlip seanlip deleted the wiki-improvements branch April 2, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants