add lighthouse recording to wiki #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@U8NWXD, The formatting and all looks fine to me but I am not sure of the content inside, so deferring to you, PTAL. |
U8NWXD
requested changes
Sep 7, 2023
Lighthouse-Tests.md
Outdated
Comment on lines
87
to
88
| Lighthouse tests might fail because the puppeteer script failed to properly set up the web page to run ligthouse tests on. To determine if | ||
| this is the case, check the log and see whether the line "Puppeteer script failed" was printed. |
There was a problem hiding this comment.
In the wiki, we don't break lines within paragraphs. This helps avoid large diffs from text re-wrapping after we just change a few words
There was a problem hiding this comment.
Understood - in the new commit, I removed these newlines within each of the paragraphs.
U8NWXD
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information about new Lighthouse Puppeteer screen recording feature to the "Debugging Lighthouse Tests" section.