Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codes.InvalidArgument when PageSize < 0 #305

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Mar 29, 2023

Fixes #298

Signed-off-by: Boris Glimcher [email protected]

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #305 (6ebaf05) into main (81f602f) will increase coverage by 0.15%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   71.63%   71.78%   +0.15%     
==========================================
  Files          14       14              
  Lines        1745     1790      +45     
==========================================
+ Hits         1250     1285      +35     
- Misses        449      459      +10     
  Partials       46       46              
Impacted Files Coverage Δ
pkg/frontend/scsi.go 0.00% <0.00%> (ø)
pkg/backend/aio.go 93.06% <100.00%> (+0.20%) ⬆️
pkg/backend/null.go 93.06% <100.00%> (+0.20%) ⬆️
pkg/backend/nvme.go 88.61% <100.00%> (+0.48%) ⬆️
pkg/frontend/blk.go 88.69% <100.00%> (+0.51%) ⬆️
pkg/frontend/nvme.go 84.57% <100.00%> (+0.36%) ⬆️
pkg/middleend/middleend.go 92.07% <100.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb glimchb marked this pull request as ready for review March 29, 2023 00:41
@glimchb glimchb requested a review from a team as a code owner March 29, 2023 00:41
@glimchb glimchb requested review from artek-koltun, intelfisz and a team and removed request for a team March 29, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the user specifies a negative value for page_size, the API must send an INVALID_ARGUMENT error.
3 participants