Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codes.Unknown -> codes.NotFound #304

Merged
merged 1 commit into from
Mar 29, 2023
Merged

codes.Unknown -> codes.NotFound #304

merged 1 commit into from
Mar 29, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Mar 29, 2023

Signed-off-by: Boris Glimcher [email protected]

Signed-off-by: Boris Glimcher <[email protected]>
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #304 (d92ccb2) into main (81f602f) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   71.63%   71.73%   +0.09%     
==========================================
  Files          14       14              
  Lines        1745     1751       +6     
==========================================
+ Hits         1250     1256       +6     
  Misses        449      449              
  Partials       46       46              
Impacted Files Coverage Δ
pkg/backend/aio.go 92.85% <100.00%> (ø)
pkg/backend/null.go 92.85% <100.00%> (ø)
pkg/backend/nvme.go 88.13% <100.00%> (ø)
pkg/frontend/blk.go 88.39% <100.00%> (+0.21%) ⬆️
pkg/frontend/nvme.go 84.36% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb glimchb marked this pull request as ready for review March 29, 2023 00:19
@glimchb glimchb requested a review from a team as a code owner March 29, 2023 00:19
Copy link

@intelfisz intelfisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other that the proposal by Artsiom to have a common place with status definition, the change looks good.

@glimchb glimchb merged commit f89a3b1 into opiproject:main Mar 29, 2023
@glimchb glimchb deleted the ci branch March 29, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants