Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (OPI CNI) This is the initial implementation of OPI CNI #7

Closed
wants to merge 1 commit into from

Conversation

mardim91
Copy link

@mardim91 mardim91 commented Dec 4, 2023

Initial implementation of OPI CNI. Currently only Intel Mt.Evans IPUs are supported by this CNI. Target is to support more IPUs/DPUs in the future. It has an integration with the EVPN GW API .

Initial implementation of OPI CNI. Currently only Intel
Mt.Evans IPUs are supported by this CNI

Signed-off-by: Dimitrios Markou <[email protected]>
@mardim91 mardim91 requested a review from a team as a code owner December 4, 2023 10:07
# Copyright (C) 2023 Network Plumping Working Group
# Copyright (C) 2023 Nordix Foundation.

FROM golang:alpine as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: containerImage not pinned by hash
Click Remediation section below to solve this issue
make clean && \
make build

FROM alpine:3

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating alpine:3 to alpine:3@sha256:34871e7290500828b39e22294660bee86d966bc0017544e848dd9a255cdf59e0
Click Remediation section below for further remediation help
Copy link

@nupurjai nupurjai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this based on multus and secondary interface?

@mardim91
Copy link
Author

Is this based on multus and secondary interface?

Yes it is

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in review

@@ -1,25 +1,25 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2023 Dell Inc, or its subsidiaries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not remove copyright

@mardim91
Copy link
Author

@glimchb In the last tsc meeting we have decided this is not the right repo to put the cni. Also the name is a bit confusing because this cni integrates directly with evpn gw api which is a use case API. So we have decided to name it differently and use the OPI-PoC repo for now. So no need to review this PR. I will close it.

@mardim91 mardim91 closed this Dec 19, 2023
@glimchb
Copy link
Member

glimchb commented Dec 19, 2023

@glimchb In the last tsc meeting we have decided this is not the right repo to put the cni. Also the name is a bit confusing because this cni integrates directly with evpn gw api which is a use case API. So we have decided to name it differently and use the OPI-PoC repo for now. So no need to review this PR. I will close it.

we can change the name, but still need new repo for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants