Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add life cycle steps into styles.css #17277

Merged

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Nov 26, 2024

Ticket

https://community.openproject.org/wp/59729

What are you trying to accomplish?

Add the life cycle step definitions' colors to styles.css so that project life cycle elements can be colored as configured.

Merge checklist

  • Added/updated tests

@ulferts ulferts requested a review from dombesz November 26, 2024 09:01
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulferts , I just have one remark.

frontend/src/global_styles/layout/_colors.sass Outdated Show resolved Hide resolved
@ulferts
Copy link
Contributor Author

ulferts commented Nov 26, 2024

The failing spec is a flickering one.

@ulferts ulferts merged commit db4fc17 into dev Nov 26, 2024
10 of 11 checks passed
@ulferts ulferts deleted the implementation/59729-put-life-cycle-steps-colors-into-stylescss branch November 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants