add note about overriding connection on backend-test #17257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kharonus
requested changes
Nov 22, 2024
| @@ -218,6 +218,16 @@ you want to see what the browsers are doing. `gvncviewer` or `vinagre` on Linux | |||
| the `docker-compose.override.yml` to access a container of a specific browser. As a default, the `chrome` container is | |||
| exposed on port 5900. The password is `secret` for all. | |||
|
|
|||
| Bear in mind that overriding the network for `backend-test`, might cause issues with selenium connecting to the browser. | |||
There was a problem hiding this comment.
I'd rephrase that into s.th. like:
Adding additional external docker networks to the test services like
backend-test(e.g. inside thedocker-compose.override.yml) breaks the functionality of the Selenium service. This results in failing tests running inside a Selenium context, like feature and UI tests.
| (Session info: chrome=130.0.6723.91) | ||
| ``` | ||
|
|
||
| If this happend just comment out the network overrides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Documentation update because I had issues.