Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/58163 project specific stage administration #17200

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Nov 13, 2024

Ticket

https://community.openproject.org/wp/58163

What are you trying to accomplish?

  • A new menu is added to the project menu below the "Project settings" labeled "Project lifecycle"
  • It looks and behaves similar to the project attributes administration.
    • Individual Toggle
    • Bulk enable/disable
    • Filtering
  • To see and access the project administration a permission is required.
    • The permissions is called "Select project stages and gates".
    • Roles having the 'edit project' permission will receive the new permission both when seeding and when migrating.
  • Within this administration, all currently existing stages and gates are listed.
    • The name and type (stage/gate) is displayed.
      • The type (rhombus for gate, arrow for stage) are displayed in the color defined for the stage/gate.
    • They are listed in the order defined in the instance's administration.
      • The order cannot be changed.
  • The project administrator can activate and deactivate a gate/stage.
  • The new functionality is hidden behind the feature flag developed as part of ###58159

Out of scope from the original requirements as of now as it has not been implemented yet:

  • Disabled stages/gates will not be displayed:
    • In the overview page
    • In the project list (see ##58160)

Screenshots

image

Changes of note

  • The settings page helpers for specs are split up into individual files. Before, it was possible to go to the various pages by visit_tab!('backlogs'). The menu however no longer uses tabs and adding all the helpers to that one page led to some cluttering in there.
  • A component for displaying the type of a life cycle has been added and documented in the lookbook.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@ulferts ulferts changed the base branch from dev to feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page November 13, 2024 11:17
@dombesz dombesz force-pushed the feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page branch 3 times, most recently from 6775f44 to 63f8af7 Compare November 14, 2024 11:22
@ulferts ulferts force-pushed the feature/58163-project-specific-stage-administration branch 4 times, most recently from 4a407ed to 79c25d6 Compare November 22, 2024 07:43
@ulferts ulferts changed the base branch from feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page to feature/58159-rename-life-cycles November 22, 2024 13:46
@ulferts ulferts force-pushed the feature/58163-project-specific-stage-administration branch from 79c25d6 to c791037 Compare November 22, 2024 13:47
Base automatically changed from feature/58159-rename-life-cycles to feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page November 22, 2024 16:19
@dombesz dombesz force-pushed the feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page branch from f829684 to c485739 Compare November 22, 2024 16:58
Base automatically changed from feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page to dev November 25, 2024 08:31
@ulferts ulferts force-pushed the feature/58163-project-specific-stage-administration branch from c791037 to 36b37a4 Compare November 25, 2024 16:44
@ulferts ulferts force-pushed the feature/58163-project-specific-stage-administration branch 4 times, most recently from 12f662e to dc71f0b Compare November 27, 2024 09:41
@ulferts ulferts force-pushed the feature/58163-project-specific-stage-administration branch from aea8297 to a2d8949 Compare November 28, 2024 10:40
@ulferts
Copy link
Contributor Author

ulferts commented Nov 28, 2024

The failing feature specs are flickering and weren't broken by the changes within this PR.

@ulferts ulferts marked this pull request as ready for review November 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant