select ext jwt provider #768
Merged
+47
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovholuknf
reviewed
Nov 14, 2024
| free_ziti_jwt_signer(&clt->signer_cfg); | ||
|
|
||
| clt->signer_cfg.client_id = cfg->client_id ? strdup(cfg->client_id) : NULL; | ||
| clt->signer_cfg.provider_url = strdup(cfg->provider_url); |
There was a problem hiding this comment.
all the others have a check first, should this also check? cfg->provider_url ? dup : NULL;?
dovholuknf
reviewed
Nov 14, 2024
| {"scope", scope}, | ||
| {"response_type", "code"}, | ||
| {"redirect_uri", default_cb_url}, | ||
| {"code_challenge", req->code_challenge}, | ||
| {"code_challenge_method", "S256"}, | ||
| {"audience", clt->signer_cfg->audience ? | ||
| clt->signer_cfg->audience : "openziti"}, | ||
| {"audience", clt->signer_cfg.audience ? |
There was a problem hiding this comment.
is there a method to be able to add additional params to the authorization endpoint? auth0 is funky about this and I think maybe zitadel was too? it'd be nice to be able to supply additional params in some way in case?
There was a problem hiding this comment.
parameters should have to come from signer config, we can add them when/if controller supports them
dovholuknf
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.