add support for network enrollment token enrollment #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ekoby
commented
Nov 7, 2024
ekoby
commented
- simplify enrollment code memory usage
- fix memory leaks
- simplify enrollment code memory usage - fix memory leaks
let calling code log errors if so desired
[fixes #766]
dovholuknf
reviewed
Nov 12, 2024
| .jwt_content = jwt, | ||
| .enroll_key = key, | ||
| .enroll_cert = cert, | ||
| .token = jwt, |
There was a problem hiding this comment.
why rename these and why would this only be a minor bump? shouldn't this be a major bump since the api is changing?
There was a problem hiding this comment.
enroll_ prefix is redundant. it is minor to be consistent with how we always versioned things
dovholuknf
reviewed
Nov 13, 2024
| if (url.query != NULL) { | ||
| // TODO magic URL | ||
| } else { | ||
| // controller URL must be verifiable with default/OS cert bundle |
There was a problem hiding this comment.
will there be a clear log message or error when trying to use network jwt without a verifiable os / cert bundle?
dovholuknf
approved these changes
Nov 13, 2024
scareything
reviewed
Nov 13, 2024
| #define ZITI_ENROLL_H | ||
|
|
||
| #include <stdbool.h> | ||
| #include "ziti_model.h" |
There was a problem hiding this comment.
should this be "ziti/ziti_model.h"? "ziti-sdk-c/includes" is the only public include dir.
There was a problem hiding this comment.
it should work "ziti_model.h" will also resolve against this file's dir
scareything
reviewed
Nov 13, 2024
| @@ -29,6 +29,7 @@ | |||
| #include "ziti_model.h" | |||
| #include "enums.h" | |||
| #include "ziti_events.h" | |||
| #include "enroll.h" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.