Add support for http connect proxying to tls connections. Fixes #54 #55
Conversation
plorenz
force-pushed
the
tls-over-http-connect-proxy
branch
from
4755c28
to
85f3ca2
Compare
plorenz
force-pushed
the
tls-over-http-connect-proxy
branch
from
85f3ca2
to
81f734f
Compare
| } | ||
|
|
||
| func (self *HttpConnectProxyDialer) Dial(network, addr string) (net.Conn, error) { | ||
| c, err := net.Dial(network, self.address) |
There was a problem hiding this comment.
This assumes the proxy server is not TLS, correct? I believe that if the HTTP proxy is using TLS this will fail to connect properly.
It looks like the net.Conn from here is expected to be used in .Connect(), which sends credentials. If HTTP is only supported, those creds are sent in the clear.
There was a problem hiding this comment.
One way to handle TLS vs non-TLS HTTP proxies is to require the protocol prefix on the address and inspect it:
https://proxyhost vs http://proxyhost and then do the right thing. However I don't know how well that pattern meshes with the transport codebase.
There was a problem hiding this comment.
Yeah, this is just to get the bare minimum working. If/when we get more feature requests we can look at how to expand this out
No description provided.