Version 3.1.0 #283
Version 3.1.0 #283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 51.13% 51.13%
=======================================
Files 21 21
Lines 1936 1936
Branches 1145 1146 +1
=======================================
Hits 990 990
- Misses 942 944 +2
+ Partials 4 2 -2
Continue to review full report at Codecov.
|
| @@ -254,7 +254,7 @@ TEST(zimcheck, integrity_goodzimfile) | |||
| { | |||
| const std::string expected_output( | |||
| "[INFO] Checking zim file data/zimfiles/good.zim" "\n" | |||
| "[INFO] Zimcheck version is 3.0.0" "\n" | |||
| "[INFO] Zimcheck version is " VERSION "\n" | |||
| "[INFO] Verifying ZIM-archive structure integrity..." "\n" | |||
There was a problem hiding this comment.
This change means that we don't care about the version string in the zimcheck output (since we test the contents of the VERSION macro via itself). Consider that the VERSION macro is carelessly redefined (#undefed and then #defined) by a header file included after zim-tools/src/version.h. Then our tests will not detect that.
This comment also applies to an earlier commit 409824a (in #208) but then we at least had a fallback in the form of this kind of checks.
I think we should preserve the version in an explicit textual form in at least one place (and better in three - output of zimcheck -v, version info in plaintext output and version info in JSON output).
There was a problem hiding this comment.
Indeed.
I was more on testing the output itself than the version.
I have created the issue #285 for this.
No description provided.