Fix low quality #73
Merged
Fix low quality #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hook - dedicated function for recompression - simple post_processing function for thumbnail and recompression - hook now just calls post_processing
- stop using youtube_dl progress hook - call post_prossing after youtube_dl is done with the video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#71 introduces a regression on
--low-qualityas our processing (recompression) was launched using the youtube_dl progress hook.This PR solves it by splitting the hook into dedicated functions and launching it after youtube_dl has completed the video download.
This should also help in transitioning to #72