Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty playlists after filtering, and after downloading videos #376

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Nov 1, 2024

Fix #375

Two problems have been fixed:

  • scraper was checking the playlist is not empty before filtering by date range, deleted videos, ... => some playlists finally empty were not detected
  • scraper was not checking wether the playlist is empty after downloading videos (we could have a majority of videos OK, but all videos of a playlist fails then the playlist is empty

@benoit74 benoit74 self-assigned this Nov 1, 2024
@benoit74 benoit74 marked this pull request as ready for review November 1, 2024 16:42
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 1.25%. Comparing base (bc1de9e) to head (8e351ba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #376      +/-   ##
========================================
- Coverage   1.25%   1.25%   -0.01%     
========================================
  Files         11      11              
  Lines       1114    1120       +6     
  Branches     163     165       +2     
========================================
  Hits          14      14              
- Misses      1100    1106       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 requested a review from rgaudin November 1, 2024 16:44
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benoit74 benoit74 merged commit 7e2dfb5 into main Nov 1, 2024
10 checks passed
@benoit74 benoit74 deleted the empty_playlist branch November 1, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yet another issue with empty playlists
2 participants