Set up db connections to use SOCKS proxy in Development environment #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #171 |
audiodude
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 90.95% 90.99% +0.03%
==========================================
Files 64 65 +1
Lines 3396 3411 +15
==========================================
+ Hits 3089 3104 +15
Misses 307 307 ☔ View full report in Codecov by Sentry. |
|
@rgaudin can you do a sanity check please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the development environment only needed to connect to the English wikipedia replica database, so it was enough to set up a ssh tunnel and connect through that. However, in future versions of the code, we will need to connect to a variety of wiki replica database, in order to select
linksandlang_links. So, for example, for French wikipedia, we will need to connect tofrwiki.analytics.db.svc.wikimedia.cloud. In fact, we will need to connect to all db replicas for all wikipedia languages.This code will not be used in production, it is only for development. In production, the
*.analytics.db.svc.wikimedia.cloudhosts are all reachable from the production cloud VPS server. For local testing and debugging, we need the SOCKS proxy.