Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial zimwriterfs clone #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added initial zimwriterfs clone #165

wants to merge 1 commit into from

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented May 27, 2024

Here's a first shot at an implementation of zimwriterfs using scraperlib.

It uses the same interface except for two missing features:

  • --inflateHtml: now sure it's useful at all
  • --skip-libmagic-check: didn't seem worth the effort for a first version

Very little code here, it's mostly CLI. I did not use make_zim_file() so we can set those creator options that zimwriterfs allows to set…

WARN: dumping this so it's not lost but not sure it's ready (haven't written any test yet)

@rgaudin rgaudin requested a review from benoit74 May 27, 2024 14:05
@rgaudin rgaudin self-assigned this May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d49831) to head (a288082).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1393      1393           
  Branches       240       240           
=========================================
  Hits          1393      1393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing much to add, aside from the fact that I don't know if we want to merge this now since you mentioned it is not sufficiently tested.

That been said, it is quite "external", so I don't mind much if we merge this now and add tests later on. It is not included in coverage report anyway ^^

@rgaudin
Copy link
Member Author

rgaudin commented May 28, 2024

There is no real need for this so it can await its tests ; I'd love to complete (or someone else) the missing features and add a workflow that builds an independent static binary as well (just to annoy @kelson42!)

@kelson42 what is the purpose of the --inflateHtml feature?

The way I understand it is that when adding files, all files which extension is considered HTML are decompressed as if those would be zip(zlib)-encoded in-place and if that fails, the raw content is added instead.

I'm curious to know what scenario lead to this ugly thing 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants