Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require delocate only on Windows #206

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Require delocate only on Windows #206

merged 3 commits into from
Sep 25, 2024

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented Sep 23, 2024

Fixes #205

@rgaudin rgaudin self-assigned this Sep 23, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (b2a4e38) to head (998ab36).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           1        1           
  Lines         523      523           
=======================================
  Hits          489      489           
  Misses         34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgaudin rgaudin marked this pull request as ready for review September 23, 2024 10:46
@rgaudin rgaudin changed the title Delocate win only Require delocate only on Windows Sep 23, 2024
benoit74
benoit74 approved these changes Sep 23, 2024
View reviewed changes
Copy link

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really an expert in wheels and delocate, but at least all this makes sense to me.

@rgaudin rgaudin merged commit a5fb036 into main Sep 25, 2024
20 checks passed
@rgaudin rgaudin deleted the delocate_win_only branch September 25, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit74 benoit74 benoit74 approved these changes

Assignees

@rgaudin rgaudin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only depend on delocate on needed platforms
2 participants
@rgaudin @benoit74