Using libzim 8.2.1 #171
Merged
Using libzim 8.2.1 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 1 1
Lines 480 480
=======================================
Hits 447 447
Misses 33 33 ☔ View full report in Codecov by Sentry. |
mgautierfr
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
LGTM.
Just want to mention the change in the dependencies version from >= to ==.
It is a bit more than just updating version number as it fixes a specific version.
If it is really want is wanted, it is ok. But better mention for nothing than let pass a unwanted change.
|
Sorry this a a WIP ; the bionic builds are broken. I am figuring it out first. |
rgaudin
force-pushed
the
8_2_1
branch
4 times, most recently
from
996c6e9
to
98f0927
Compare
|
Blocked by #170 |
Re-run of build/setup could be compromised by the presence of previous libraries or headers
Previous post-processing cleanup was breaking editable installs Instead, this manual `setup.py clean` command is provided as convenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.