Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated libzim v6 to v8 #1637

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Updated libzim v6 to v8 #1637

wants to merge 8 commits into from

Conversation

kelvinhammond
Copy link
Collaborator

@kelvinhammond kelvinhammond commented Jun 30, 2022

Work in progress, working on running tests right now.
Libzim7 port still needs some work, there are outstanding nodejs or node-libzim issues that need to be addressed.
Once node-libzim for libzim7 has been released this PR can continue.

TODO

  • Make sure tests pass
  • Update package.json and package-lock.json to not use branch for openzim/libzim

@kelvinhammond kelvinhammond changed the title Initial work updating libzim to libzim7 Updated libzim v6 to v7 Jun 30, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 10, 2022
@stale stale bot removed the stale label Jul 19, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@kelvinhammond
Copy link
Collaborator Author

I forgot about this, I'll try to work on it when I get time.

@stale stale bot removed the stale label Sep 22, 2022
@kelson42
Copy link
Collaborator

kelson42 commented Sep 25, 2022

@kelvinhammond Meanwhike this libzim8! Renaming ticket.

@kelson42 kelson42 changed the title Updated libzim v6 to v7 Updated libzim v6 to v8 Sep 25, 2022
@kelson42
Copy link
Collaborator

@kelvinhammond Any news?

@kelvinhammond
Copy link
Collaborator Author

kelvinhammond commented Oct 16, 2022

I'm working on the tests still.

To be more specific, I'm working on upgrading redis, fixing tests with the new typescript version, etc.

@kelson42
Copy link
Collaborator

@kelvinhammond great, someone else will work on https://github.com/openzim/mwoffliner/milestone/20 in the next days. Hopefully without steping on your foots.

@kelvinhammond
Copy link
Collaborator Author

Rebased with master

@stale
Copy link

stale bot commented Nov 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 2, 2022
@stale stale bot removed the stale label Nov 5, 2022
@kelvinhammond
Copy link
Collaborator Author

I forget why this is taking so long.

  1. I don't have much time between life and work.
  2. I think I'm having to update typescript so that it works with libzim8's typescript.

Maybe I'll rethink this PR, for now I'll continue on it when I have time.

@kelson42
Copy link
Collaborator

kelson42 commented Nov 6, 2022

@kelvinhammond Trying to update typescript and to latest version of module anymway independently of this PR.

@stale
Copy link

stale bot commented May 26, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants