-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of os.path and path.py with pathlib #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks very good, only minor comments to discuss (not sure I'm right on all of them ^^)
@benoit74 , I have made the necessary fixes but I'm unable to run the full check anymore as my VM instance on GCP keeps running out of space (over 20Gb). However, I can verify that the previous commands run to full completion |
That's enough for me, we will make a full run before releasing this anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #195
Rationale
Use
pathlib.Path
for all path operations instead of a combination ofos.path
andpath.py
.Changes
os.path
andpath.py
topathlib.Path
os.path.join