iprule: amend ipproto netlink nla_put_u32 to nla_put_u8 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRA_IP_PROTO expects an 8 bit value. Follow-up fix for d29cf70. uint8 prevents the kernel log message: netlink: 'netifd': attribute type 22 has an invalid length. The message is otherwise harmless; ip rules using ipproto are created successfully. Tested on 24.10-snapshot Signed-off-by: Paul Donald <[email protected]>
|
What can we do to draw attention to our pull requests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FRA_IP_PROTO expects an 8 bit value.
Follow-up fix for d29cf70.
uint8 prevents the kernel log message:
netlink: 'netifd': attribute type 22 has an invalid length.The message is otherwise harmless; ip rules using ipproto are created successfully.
Tested on 24.10-snapshot
ping @nbd168 - sorry for the noise.