netifd: iprule add sport #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was missing the ip rule for `sport` in netifd and although I have a working C knowledge, I have little netlink knowledge and it is the first time I looked into netifd but after some research I could come up with a working patch to implement `option sport`. But if you decide to implement it, it needs careful review as I might have overlooked something and/or there might be a better/more efficient way to implement this. Compile tested on DL-WRX36 (ipq8074) running Main Snapshot Example 1: ``` config rule option src '192.168.9.23/32' option sport '1194' option lookup 'main' ``` Result: ``` root@DL-WRX36:~# ip ru 0: from all lookup local 1: from 192.168.9.23 sport 1194 lookup main ``` Example 2 range: ``` config rule option src '192.168.9.23/32' option sport '1194-1195' option lookup 'main' ``` Result: ``` root@DL-WRX36:~# ip ru 0: from all lookup local 1: from 192.168.9.23 sport 1194-1195 lookup main ``` Signed-off-by: Erik Conijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing the ip rule for
sportin netifd and although I have a working C knowledge, I have little netlink knowledge and it is the first time I looked into netifd but after some research I could come up with a working patch to implementoption sport. But if you decide to implement it, it needs careful review as I might have overlooked something and/or there might be a better/more efficient way to implement this.Compile tested on DL-WRX36 (ipq8074) running Main Snapshot
Example 1:
Result:
Example 2 range:
Result:
Signed-off-by: Erik Conijn [email protected]