Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Notification batching documentation #308

Merged
merged 9 commits into from
Sep 2, 2024

Conversation

Dhanus3133
Copy link
Member

@Dhanus3133 Dhanus3133 commented Aug 25, 2024

Closes: #306

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress @Dhanus3133.

See my coments below.

I think we could move this information as a subsection of to https://github.com/openwisp/openwisp-notifications/blob/master/docs/user/web-email-notifications.rst, which seems to already touch the subject, @pandafy what do you think about this?

Please add a line mentioning this feature in https://github.com/openwisp/openwisp-notifications/blob/master/docs/user/intro.rst just under email notifications.

docs/user/batch-email-notifications.rst Outdated Show resolved Hide resolved
docs/user/batch-email-notifications.rst Outdated Show resolved Hide resolved
@pandafy
Copy link
Member

pandafy commented Aug 26, 2024

I think we could move this information as a subsection of to https://github.com/openwisp/openwisp-notifications/blob/master/docs/user/web-email-notifications.rst, which seems to already touch the subject, @pandafy what do you think about this?

I agree here.

1 similar comment
@pandafy
Copy link
Member

pandafy commented Aug 26, 2024

I think we could move this information as a subsection of to https://github.com/openwisp/openwisp-notifications/blob/master/docs/user/web-email-notifications.rst, which seems to already touch the subject, @pandafy what do you think about this?

I agree here.

docs/user/settings.rst Outdated Show resolved Hide resolved
docs/user/batch-email-notifications.rst Outdated Show resolved Hide resolved
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress @Dhanus3133, please squash the commits so we have 1 commit for the CSS changes first, and the docs changes after, which I will rework.

See also my comment below.

docs/user/web-email-notifications.rst Outdated Show resolved Hide resolved
docs/user/web-email-notifications.rst Outdated Show resolved Hide resolved
@nemesifier nemesifier merged commit bcf58fb into gsoc24-rebased Sep 2, 2024
12 checks passed
@nemesifier nemesifier deleted the notification-batching-docs branch September 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants