Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Added generic message notification type (shown in dialg box) #275
[feature] Added generic message notification type (shown in dialg box) #275
Changes from 28 commits
c207c9d
1025bfb
2605a09
bf3ba25
a15a284
3a0377d
2be7037
581cc90
a7c792d
9e7c1fc
2608c11
2a922a6
0686c2d
8106f3e
cc528df
aca39bc
1e6b840
00ec345
e69600f
bbff510
8dfcfce
df10915
6e5db98
6de368f
b0725b1
9ed5982
4a9956b
4593ef3
9f11de6
b09cd6f
8229268
08ab21b
69bfb39
0020c21
859734e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of performing these operations in the
__init__
, but the target_link is dynamic based on whether we are using the message in the email.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required because we handle the target URL differently when we send the email.
The email includes a ridrect URL, which flags the notification as read and then redirects the user to the target object.