[change] Added the name of the metric to the label #311 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the signal charts didn't have a metric name so the following changes were made. Signal Strength -> Signal Strength (RSSI) Signal Power -> Signal Power (RSRP) Signal Quality -> Signal Quality (RSRQ) Signal to Noise Ratio -> Signal to Noise Ratio (SNR) Fixes openwisp#311
|
@pandafy This time I have run the run-qa-checks with all checks successful and hoping no problems occur. |
|
@Priyanshu-Batham the QA checks are still failing. Do you want to continue working on this PR? |
|
@pandafy yes sir, am currently out of station and will be back on Sunday. I'll fix it ASAP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the signal charts didn't have a metric name so the following changes were made.
Signal Strength -> Signal Strength (RSSI)
Signal Power -> Signal Power (RSRP)
Signal Quality -> Signal Quality (RSRQ)
Signal to Noise Ratio -> Signal to Noise Ratio (SNR)
Fixes #311