[fix] Both 'rx_bytes' and 'tx_bytes' are present #595 #603
+38
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praptisharma28
force-pushed
the
rxtx
branch
from
64f6514 to
cbf7e7a
Compare
nemesifier
reviewed
Nov 6, 2024
There was a problem hiding this comment.
The tests weren't useful, they weren't failing without the fix.
Also, I think the fix should be to make sure we write the interface stats as long as we get either rx_bytes or tx_bytes, while the patch proposed here would write only if both are present.
I pushed a real fix, please have a look, you can try running tests with:
./manage.py test openwisp_monitoring.device.tests.test_api.TestDeviceApi.test_missing_rx_bytes openwisp_monitoring.device.tests.test_api.TestDeviceApi.test_missing_tx_bytes
If you change the code in openwisp_monitoring/device/writer.py to reset it to the previous state, you should see both tests failing. That's how we do it.
nemesifier
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
Checklist
I have read the OpenWISP Contributing Guidelines.
I have manually tested the changes proposed in this pull request.
I have written new test cases for new code and/or updated existing tests for changes to existing code.
I have updated the documentation.
Both 'rx_bytes' and 'tx_bytes' are present in the statistics.
Neither of them is None, which allows for zero values (as per the comment).
Closes #595