[change] Respect disabled organizations #552 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Nov 22, 2023
openwisp_monitoring/device/apps.py
Outdated
| @classmethod | ||
| def organization_post_save_receiver(cls, instance, *args, **kwargs): | ||
| if instance.is_active is False: | ||
| from .tasks import organization_disabled_handler |
There was a problem hiding this comment.
is the import here necessary?
There was a problem hiding this comment.
Yes, because openwisp_monitoring.device.tasks imports openwisp_monitoring.checks.tasks.perform_check which in-turn imports the ContentType model globally.
pandafy
force-pushed
the
issues/552-disabled-organization
branch
from
5735ef8 to
1fe816f
Compare
nemesifier
reviewed
Nov 28, 2023
| @@ -155,27 +155,6 @@ def test_400(self): | |||
| ) | |||
| self.assertEqual(r.status_code, 400) | |||
|
|
|||
| def test_200_none(self): | |||
There was a problem hiding this comment.
why is this test being removed?
nemesifier
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #552
Checks: