additional error checking in ping script #553
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made command build "more correct"
Argument Splitting: Usually, each argument and the command itself are separate elements in the list. If any of the flags or options require values (like -c 5), those should usually also be separate elements in the list.
Implement try catch block in _command to catch any errors from the shell.
Returning the commands exit code.
Check exit code and if it is NOT zero(0)=all the pinged hosts are reachable -or- one(1)=Some hosts were unreachable. Then raise an error to improve (speed up) troubleshooting.
Checks: