Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal charts: add the name of the metric to the label #311

Open
ghost opened this issue Jul 22, 2021 · 3 comments · May be fixed by #621
Open

Signal charts: add the name of the metric to the label #311

ghost opened this issue Jul 22, 2021 · 3 comments · May be fixed by #621
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Jul 22, 2021 •
edited by ghost
Loading

On the signal charting, can we please add the name of the metric being measured to the signal charts so they get renamed as follows, just to remove any doubts the user may have about what it is

Signal Strength -> Signal Strength (RSSI)
Signal Power -> Signal Power (RSRP)
Signal Quality -> Signal Quality (RSRQ)
Signal to Noise Ratio -> Signal to Noise Ratio (SNR)
@ghost ghost changed the title Add the name of the metric to the label Signal charts: add the name of the metric to the label Jul 22, 2021
@nemesifier nemesifier added the enhancement New feature or request label Sep 23, 2021
@pandafy pandafy added the good first issue Good for newcomers label Feb 28, 2024
@nemesifier nemesifier moved this to To do (general) in OpenWISP Contributor's Board Aug 21, 2024
@Priyanshu-Batham
Copy link

@nemesifier @pandafy may I work on this issue please?

@pandafy
Copy link
Member

pandafy commented Nov 13, 2024

@Priyanshu-Batham yes, go ahead.

@Priyanshu-Batham Priyanshu-Batham mentioned this issue Nov 27, 2024
Closed
@Priyanshu-Batham
Copy link

@pandafy I ran the run-qa-checks also and it now ran successfully without any issues.
image

Priyanshu-Batham added a commit to Priyanshu-Batham/openwisp-monitoring that referenced this issue Nov 28, 2024
@Priyanshu-Batham
[change] Added the name of the metric to the label openwisp#311
f2f06e1 
Previously the signal charts didn't have a metric name so the following changes were made.
Signal Strength -> Signal Strength (RSSI)
Signal Power -> Signal Power (RSRP)
Signal Quality -> Signal Quality (RSRQ)
Signal to Noise Ratio -> Signal to Noise Ratio (SNR)

Fixes openwisp#311
Priyanshu-Batham added a commit to Priyanshu-Batham/openwisp-monitoring that referenced this issue Nov 28, 2024
@Priyanshu-Batham
[change] Added the name of the metric to the label openwisp#311
2d7faf4 
Previously the signal charts didn't have a metric name so the following changes were made.
Signal Strength -> Signal Strength (RSSI)
Signal Power -> Signal Power (RSRP)
Signal Quality -> Signal Quality (RSRQ)
Signal to Noise Ratio -> Signal to Noise Ratio (SNR)

Fixes openwisp#311
@Priyanshu-Batham Priyanshu-Batham linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
OpenWISP Contributor's Board
Status: To do (general)
Milestone
No milestone
3 participants
@nemesifier @pandafy @Priyanshu-Batham