[fix] Allow updating templates with invalid configurations #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, fixing an invalid template configuration via the UI was blocked due to the cache invalidation mechanism. This mechanism attempted to evaluate the existing configuration, triggering a ValidationError and preventing updates.
pandafy
force-pushed
the
allow-fixing-faulty-config
branch
from
04a69b9 to
bd3d11a
Compare
Related to #948
nemesifier
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
A new regression prevented fixing an invalid template configuration via the UI: the cache invalidation mechanism triggered the evaluation of the configuration which can fail if the configuration is invalid (eg: due to schema updates), hence there was an uncaught ValidationError bubbling up and preventing updates.
This patch fixes this issue.