[change] Notify users of background subnet division rule errors #837 #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/837-notify-sdr
branch
from
35b43a6 to
7f606f4
Compare
nemesifier
reviewed
May 31, 2024
| action_object=master_subnet, | ||
| level='error', | ||
| message=( | ||
| 'Failed to provision subnets for' |
There was a problem hiding this comment.
shouldn't we flag these strings as translatable?
nemesifier
reviewed
Jun 17, 2024
.github/workflows/ci.yml
Outdated
| @@ -72,6 +72,8 @@ jobs: | |||
| - name: Install openwisp-controller | |||
| run: | | |||
| pip install -U -e . | |||
| # TODO: Remove before merging | |||
| pip install -IU --no-deps "openwisp-notifications @ https://github.com/Dhanus3133/openwisp-notifications/tarball/feat/display-description-notification-dialog" | |||
pandafy
force-pushed
the
issues/837-notify-sdr
branch
from
8139b76 to
188e393
Compare
nemesifier
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #837
Blockers