Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gestures: Fix flick gesture on non-desktop builds #16

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Shfty
Copy link
Contributor

@Shfty Shfty commented Nov 4, 2012

When building for device, the flick gesture wasn't being compiled in- these changes include and use it regardless of platform.

Open-webOS-DCO-1.0-Signed-off-by: Josh Palmer [email protected]

@RS102839
Copy link
Contributor

RS102839 commented Nov 4, 2012

Thanks for the submission.

We are evaluating to make sure there aren't any unintended consequences.

@ericblade-owo
Copy link
Contributor

This does not currently build in Desktop, looks like a missing include. If you can patch that up, I can continue checking it out. Thanks!

Src/base/hosts/HostQtDesktop.cpp: In member function ‘virtual bool GestureStrip::event(QEvent_)’:
Src/base/hosts/HostQtDesktop.cpp:126:16: error: invalid use of incomplete type ‘struct QGesture’
../../luna-desktop-binaries/staging/include/QtGui/qevent.h:72:7: error: forward declaration of ‘struct QGesture’
Src/base/hosts/HostQtDesktop.cpp:127:6: error: ‘FlickGesture’ was not declared in this scope
Src/base/hosts/HostQtDesktop.cpp:127:20: error: ‘fg’ was not declared in this scope
Src/base/hosts/HostQtDesktop.cpp:127:37: error: expected type-specifier before ‘FlickGesture’
Src/base/hosts/HostQtDesktop.cpp:127:37: error: expected ‘>’ before ‘FlickGesture’
Src/base/hosts/HostQtDesktop.cpp:127:37: error: expected ‘(’ before ‘FlickGesture’
Src/base/hosts/HostQtDesktop.cpp:127:50: error: expected primary-expression before ‘>’ token
Src/base/hosts/HostQtDesktop.cpp:127:60: error: expected ‘)’ before ‘;’ token
make: *_* [debug-x86/.obj/HostQtDesktop.o] Error 1

@ericblade-owo
Copy link
Contributor

ShiftyAxel and I have discussed this patch, and it's not something that's relevant to everywhere, but it would be nice to see it added as a compatibility option for systems that do not have operating multi-touch input, but rather use mouse emulation for the touch screen. Hoping he will commit it with the changes we discussed for that.

morphis and others added 8 commits December 19, 2012 10:26
Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
On some platforms we don't have a second framebuffer so until now some statements in the
init method where never reached on these platforms.

Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
On newer kernels /proc/*/oom_adj is deprecated and should not be used anymore. As Open
webOS requires at least a linux 3.3 kernel this changes the use to the new
/proc/*/oom_score_adj entry but still keeps backward compatiblity for older kernels which
onles provides /proc/*/oom_adj.

More information about the change are available on the following pages:
- torvalds/linux@a63d83f#include/linux/oom.h
- https://www.redhat.com/archives/lvm-devel/2011-July/msg00097.html

Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
When compiling for a target device this will lead to build errors when the device has no
support for the media api.

Open-WebOS-DCO-1.0-Signed-Off-By: Simon Busch <[email protected]>
There is difference in the way of compiling serviceinstaller: When compiling it with cmake
it will result in a library called libserviceinstaller and if the plain Makefile is used
it will named libserviceinstall. OE uses the cmake approach and therefore we need to fix
this.

Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
* Remove FlickGestureRecognizer from HostQtDesktop.cpp
* Add FlickGestureRecognizer to WindowServer.cpp
* Move recognizer file entries from desktop.pri to sysmgr.pro

Open-webOS-DCO-1.0-Signed-off-by: Josh Palmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants