Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Sync Ruff version in configs and apply formatting #3358

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented Nov 27, 2024

Following up on #3348

@ff137 ff137 changed the title ⬆️ Upgrade pre-commit, lint workflow, and apply new formatting 🎨 Sync Ruff version in configs and apply formatting Nov 27, 2024
Copy link

sonarcloud bot commented Nov 27, 2024

command, "execute", mock.MagicMock()
) as mock_execute:
with (
mock.patch.object(command, "__name__", "__main__") as mock_name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started removing these variables (mock_name) when they aren't used. It's not important but makes the code slightly cleaner. Doesn't have to happen in this PR.

@jamshale jamshale merged commit eb52b05 into openwallet-foundation:main Nov 27, 2024
10 checks passed
@ff137 ff137 deleted the update-ruff branch November 27, 2024 20:36
ff137 added a commit to didx-xyz/acapy that referenced this pull request Nov 27, 2024
…ation#3358)

* ⬆️ Upgrade ruff version in pre-commit config and lint workflow

Signed-off-by: ff137 <[email protected]>

* 🎨 Apply ruff formatting

Signed-off-by: ff137 <[email protected]>

* ⬆️ Upgrade pre-commit hook version

Signed-off-by: ff137 <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants