Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore --base-wallet-routes flag functionality #3344

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

esune
Copy link
Member

@esune esune commented Nov 21, 2024

Resolves #3283

The tenant_authentication has been updated to also allow access to the base wallet when the route matches a path defined using --base-wallet-routes.

Please note that, when compared to the previous implementation, the matcher has been made more greedy to tighten security: if an extra route of /test is specified, the matcher will only match that and not /testA or /test-something-else as it appears it would have done before.

One drawback of having to use this matcher inside the decorator is that I could not think of an elegant way of caching the compiled pattern for reuse - suggestions on how to achieve that, if desirable/required, will be welcome.

jamshale
jamshale previously approved these changes Nov 21, 2024
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbluhm
Copy link
Contributor

dbluhm commented Nov 21, 2024

Thanks @esune! I will test this in the scenario we're using and report back whether it works as expected.

@dbluhm dbluhm force-pushed the fix/base-wallet-extra-routes branch from 1ce3074 to 88be790 Compare November 22, 2024 22:37
@dbluhm dbluhm merged commit fc6f35d into openwallet-foundation:main Nov 22, 2024
9 checks passed
Copy link

sonarcloud bot commented Nov 22, 2024

@esune esune deleted the fix/base-wallet-extra-routes branch November 25, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--base-wallet-routes flag no longer works
3 participants