Crypto type improvements #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 4, 2024
michielp1807
force-pushed
the
crypto-type-improvements
branch
from
1b96c84 to
b7b7a9e
Compare
Signed-off-by: Michiel <[email protected]>
Signed-off-by: Michiel <[email protected]>
michielp1807
force-pushed
the
crypto-type-improvements
branch
from
b7b7a9e to
f1577bb
Compare
Signed-off-by: Michiel <[email protected]>
tweedegolf-marc
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
This PR also refactors the back-end crypto modules to remove duplication, nice!
I have one nitpick about how to communicate the cryptotype/signature type to the caller, but that can be fixed in a different PR if we choose and I'm fine with the code merged as-is.
Signed-off-by: Michiel <[email protected]>
Signed-off-by: Michiel <[email protected]>
tweedegolf-marc
merged commit ff20159
into
openwallet-foundation-labs:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-quantum (pq) mode is not (yet) part of the crypto type as this mode is still experimental, and it does currently not support communication with other modes.