Issue #33 fix different algorithms matching #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzizMukhtorjonov
deleted the
issue-33-fix-different-algorithms-matching
branch
AzizMukhtorjonov
restored the
issue-33-fix-different-algorithms-matching
branch
akarabashov
reviewed
Sep 10, 2024
akarabashov
reviewed
Sep 10, 2024
akarabashov
reviewed
Sep 10, 2024
akarabashov
reviewed
Sep 10, 2024
AzizMukhtorjonov
force-pushed
the
issue-33-fix-different-algorithms-matching
branch
3 times, most recently
from
a4064d5 to
bdf1498
Compare
Abdulbois
reviewed
Sep 10, 2024
AzizMukhtorjonov
force-pushed
the
issue-33-fix-different-algorithms-matching
branch
2 times, most recently
from
1703544 to
e16becd
Compare
…fferent algorithm. Resolves openwallet-foundation-labs#33 Signed-off-by: Aziz Mukhtorjonov <[email protected]>
…fferent algorithm. Resolves openwallet-foundation-labs#33 Signed-off-by: Aziz Mukhtorjonov <[email protected]>
…dling to unwrap; Issue openwallet-foundation-labs#33 Signed-off-by: Aziz Mukhtorjonov <[email protected]>
Signed-off-by: Aziz Mukhtorjonov <[email protected]>
AzizMukhtorjonov
force-pushed
the
issue-33-fix-different-algorithms-matching
branch
from
e16becd to
53ef9b8
Compare
jovfer
reviewed
Oct 2, 2024
src/verifier.rs
Outdated
| @@ -69,6 +69,13 @@ impl SDJWTVerifier { | |||
| verifier.verified_claims = verifier.extract_sd_claims()?; | |||
|
|
|||
| if let (Some(expected_aud), Some(expected_nonce)) = (&expected_aud, &expected_nonce) { | |||
| let sign_alg = verifier.sd_jwt_engine.unverified_input_key_binding_jwt | |||
| .clone() | |||
There was a problem hiding this comment.
cloned value here is used by ref below. Can it be siplified?
There was a problem hiding this comment.
Removed cloning & use reference instead
Signed-off-by: Aziz Mukhtorjonov <[email protected]>
jovfer
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aziz Mukhtorjonov [email protected]