[NPUW] Fix for weights bank UIDs #28297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smirnov-alexey
added
Code Freeze
category: NPU
dmatveev
approved these changes
Jan 7, 2025
Comment on lines
+85
to
+90
| std::unique_lock storage_guard(device_bank.mutex); | ||
| vec.reserve(device_bank.storage.size()); | ||
| for (const auto& el : device_bank.storage) { | ||
| vec.push_back(el.second.lt); | ||
| } | ||
| storage_guard.unlock(); |
There was a problem hiding this comment.
So if I understand this code correctly (aside of the lock guards), it seems to me you first iterate over all (say, 400) registered lazy tensors in the bank to make a job list, and then run over it in parallel_for() to evaluate and allocate.
Under the parallel_for(), you check if the tensor is already allocated.
On the first run (prefill compile), this code will work as expected - you will evaluate, allocate, and copy all ~400 tensors.
On the second run you have these 400 tensors in the bank already and you add it to the list regardless, then fire up all the threads to basically do a no-op.
I'd recommend to only add tensors which were not allocated to this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #28282