Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to C++17 as default standart #28273

Merged

Conversation

dmitry-gorokhov
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov commented Jan 6, 2025

Details:

Dependencies:

Tickets:

@dmitry-gorokhov dmitry-gorokhov added this to the 2025.0 milestone Jan 6, 2025
@dmitry-gorokhov dmitry-gorokhov requested review from a team as code owners January 6, 2025 05:39
@dmitry-gorokhov dmitry-gorokhov requested review from akopytko and ilya-lavrenov and removed request for a team January 6, 2025 05:39
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra category: samples OpenVINO Runtime Samples category: dependency_changes Pull requests that update a dependency file category: docs_snippets OpenVINO docs snippets (docs/snippets) labels Jan 6, 2025
@rkazants
Copy link
Contributor

rkazants commented Jan 6, 2025

looks build error:

[ 37%] Building CXX object src/core/CMakeFiles/openvino_core_obj.dir/src/op/grn.cpp.o
In file included from /__w/openvino/openvino/openvino/src/common/transformations/src/transformations/common_optimizations/simplify_shape_of_sub_graph.cpp:5:
/__w/openvino/openvino/openvino/src/common/transformations/include/transformations/common_optimizations/simplify_shape_of_sub_graph.hpp:49:10: warning: private field 'm_use_shapes' is not used [-Wunused-private-field]
    bool m_use_shapes;
         ^
1 warning generated.
[ 37%] Building CXX object 

@ilya-lavrenov
Copy link
Contributor

Please, update this place as well:

target_compile_features(${TARGET_NAME} PUBLIC cxx_std_11)

@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label Jan 6, 2025
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Jan 7, 2025
Merged via the queue into openvinotoolkit:master with commit 7318165 Jan 7, 2025
188 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: dependency_changes Pull requests that update a dependency file category: docs_snippets OpenVINO docs snippets (docs/snippets) category: inference OpenVINO Runtime library - Inference category: samples OpenVINO Runtime Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants