Title: Update build instructions for Windows (Enable Wheel Flag) #28256
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request updates the build instructions for Windows in the README. Specifically, the -DENABLE_WHEEL flag has been moved to step 3 (cmake command) instead of step 4 (cmake --build . command) due to an MS error encountered when following the original instructions.
Changes:
Updated the README to reflect the corrected command in step 3.
Reason for Change:
Adding the -DENABLE_WHEEL flag in step 4 caused an MS build error.
By moving the flag to step 3, the build was successful, and we achieved a passing build.
Testing:
Tested on Windows.
Verified successful build with the updated instructions.
Tickets:
N/A