[PT FE] Add aten::rot90 #28224
Open
[PT FE] Add aten::rot90 #28224
+107
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvafin
requested changes
Dec 30, 2024
| } else if (k == 2) { | ||
| size_t dims_size = dims.size(); | ||
| auto flip_dims = context.mark_node(v0::Constant::create(element::i32, Shape{dims_size}, dims)); | ||
| rotated = create_flip(input, flip_dims); |
There was a problem hiding this comment.
This fails to build with error:
/__w/openvino/openvino/openvino/src/frontends/pytorch/src/op/rot90.cpp: In function 'ov::OutputVector ov::frontend::pytorch::op::translate_rot90(const ov::frontend::pytorch::NodeContext&)':
/__w/openvino/openvino/openvino/src/frontends/pytorch/src/op/rot90.cpp:46:24: error: 'create_flip' was not declared in this scope
46 | auto flipped = create_flip(input, flip_dims);
| ^~~~~~~~~~~
/__w/openvino/openvino/openvino/src/frontends/pytorch/src/op/rot90.cpp:56:19: error: 'create_flip' was not declared in this scope
56 | rotated = create_flip(input, flip_dims);
| ^~~~~~~~~~~
There is no such function as create_flip
| num_inputs_check(context, 1, 3); | ||
| auto input = context.get_input(0); | ||
| int k = context.input_is_none(1) ? 1 : context.const_input<int64_t>(1); | ||
| std::vector<int64_t> dims = context.input_is_none(2) ? std::vector<int64_t>{0, 1} |
There was a problem hiding this comment.
Instead of const_input get dims as Node using get_input and use as is. To avoid requirement for it to be const and to avoid creating a Constant with dims later.
Comment on lines
+36
to
+38
| for (auto& dim : dims) { | ||
| dim = (dim + ndims) % ndims; | ||
| } |
There was a problem hiding this comment.
Use normalize_axis function for this after you change dims to be a Node rather then constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: