Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPUW Hotfixes: Memory and L0 pipeline #27826

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

dmatveev
Copy link
Contributor

@dmatveev dmatveev commented Nov 29, 2024

Details:

  • Keep tensors for decompression cut-off in a host-side closure, not lazy tensor - so they are not uploaded to bank & detached after that
    • This leads to 2x memory consumption and the subsequent crash
  • Relaxed requirements to enable the unfolded execution - so it may still happen if there's single-call functions that require DCOFF (previously having those would reject this unfolded path

Tickets:

  • C-155523 (most likely, related to)

@smirnov-alexey please take care of the release branch cherry-pick

- Keep tensors for decompression cut-off in a host-side closure, not lazy
  tensor - so they are not uploaded to bank & detached after that
  - This leads to 2x memory consumption and the subsequent crash
- Relaxed requirements to enable the unfolded execution - so it may
  still happen if there's single-call functions that require DCOFF
  (previously having those would reject this unfolded path)path
@dmatveev dmatveev self-assigned this Nov 29, 2024
@dmatveev dmatveev requested review from a team as code owners November 29, 2024 12:14
@dmatveev dmatveev added this to the 2024.6 milestone Nov 29, 2024
@github-actions github-actions bot added category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Nov 29, 2024
@dmatveev dmatveev added this pull request to the merge queue Nov 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 29, 2024
### Details:
- Keep tensors for decompression cut-off in a host-side closure, not
lazy tensor - so they are not uploaded to bank & detached after that
  - This leads to 2x memory consumption and the subsequent crash
- Relaxed requirements to enable the unfolded execution - so it may
still happen if there's single-call functions that require DCOFF
(previously having those would reject this unfolded path

### Tickets:
 - C-155523 (most likely, related to)

@smirnov-alexey please take care of the release branch cherry-pick
Merged via the queue into openvinotoolkit:master with commit aafb3fc Nov 29, 2024
148 checks passed
@dmatveev dmatveev deleted the dm/npuw_mem_hotfixes branch November 29, 2024 19:30
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2024
Mirror of #27826
Prerequisites:
#27825
#27798
#27799

---------

Co-authored-by: Dmitry Matveev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants