Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kleidiai as thirdparty #27331

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add kleidiai as thirdparty #27331

wants to merge 16 commits into from
+374 −8

Conversation

mory91
Copy link
Contributor

@mory91 mory91 commented Oct 30, 2024

Details:

  • This PR aims to add KleidiAI third-party library.

@mory91 mory91 requested review from a team as code owners October 30, 2024 09:09
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra category: dependency_changes Pull requests that update a dependency file labels Oct 30, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Oct 30, 2024
@mory91 mory91 force-pushed the add-kleidiai-thirdparty branch from f05c178 to 4b52286 Compare October 30, 2024 09:18
@dmitry-gorokhov dmitry-gorokhov self-assigned this Oct 30, 2024
@dmitry-gorokhov dmitry-gorokhov added the platform: arm OpenVINO on ARM / ARM64 label Oct 30, 2024
@alvoron
Copy link
Contributor

alvoron commented Nov 25, 2024

build_jenkins

@mory91 mory91 requested a review from a team as a code owner November 28, 2024 07:53
@mory91 mory91 requested review from ilya-lavrenov and removed request for a team November 28, 2024 07:53
@alvoron
Copy link
Contributor

alvoron commented Nov 28, 2024

build_jenkins

ilya-lavrenov
ilya-lavrenov requested changes Nov 28, 2024
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/plugins/intel_cpu/CMakeLists.txt Outdated Show resolved Hide resolved
src/plugins/intel_cpu/thirdparty/CMakeLists.txt Outdated Show resolved Hide resolved
src/plugins/intel_cpu/CMakeLists.txt
@@ -175,6 +176,11 @@ if(DNNL_USE_ACL)
set(OV_CPU_WITH_ACL ON)
endif()

if(ENABLE_KLEIDIAI_FOR_CPU)
add_definitions(-DOV_CPU_WITH_KLEIDIAI)
set(OV_CPU_WITH_KLEIDIAI ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's not used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to use it later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, why ENABLE_KLEIDIAI_FOR_CPU is not enough?

src/plugins/intel_cpu/CMakeLists.txt Outdated Show resolved Hide resolved
src/plugins/intel_cpu/CMakeLists.txt Outdated Show resolved Hide resolved
src/plugins/intel_cpu/CMakeLists.txt Outdated Show resolved Hide resolved
@alvoron
Copy link
Contributor

alvoron commented Nov 28, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Nov 29, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Nov 29, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Nov 29, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Nov 29, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Nov 29, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Nov 29, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Dec 2, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Dec 2, 2024

build_jenkins

@alvoron
Copy link
Contributor

alvoron commented Dec 3, 2024

build_jenkins

praasz
praasz reviewed Dec 17, 2024
View reviewed changes
src/plugins/intel_cpu/tests/functional/utils/cpu_test_utils.cpp
@@ -218,8 +218,8 @@ void CPUTestsBase::CheckPluginRelatedResultsImpl(const std::shared_ptr<const ov:

auto primType = getExecValue(ov::exec_model_info::IMPL_TYPE);

ASSERT_TRUE(primTypeCheck(primType))
<< "primType is unexpected : " << primType << " Expected : " << selectedType;
// ASSERT_TRUE(primTypeCheck(primType))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: build OpenVINO cmake script / infra category: CPU OpenVINO CPU plugin category: dependency_changes Pull requests that update a dependency file ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mory91 @alvoron @ilya-lavrenov @praasz @dmitry-gorokhov @sys-openvino-ci