Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requirements_2024.3.txt #712

Conversation

wgzintel
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the category: llm_bench Label for tool/llm_bench folder label Jul 31, 2024
@wgzintel wgzintel requested a review from peterchen-intel July 31, 2024 09:13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already on 2024.3 branch, why do we need such requirements file?

Copy link
Collaborator

@peterchen-intel peterchen-intel Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov as part of reproducibility insurance, we add this file to record the versions of dependencies which have been validated by validation team.
By the way, this is the requirements.txt file for benchmark.py and convert.py which are not part of genai pacakge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do it directly in requirements.txt file ?
Once we release 2024.3, we can fix all the dependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openvinotoolkit/openvino.genai/blob/releases/2024/3/llm_bench/python/requirements.txt has loser version limitation which allows different 3rd version number.

diffusers==0.29.2
openvino==2024.3.0
#optimum is in dependency list of optimum-intel
git+https://github.com/huggingface/optimum-intel.git@439d61f79cf55d5d0b28334f577b6ac3c5ced28f#egg=optimum-intel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not final validation commit of optimum-intel for release (with GPU accuracy bugs), please use pinned in branch commit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@wgzintel wgzintel force-pushed the guozhong/add_requirements_2024_3 branch from df5f48f to faf0bee Compare August 16, 2024 15:48
@peterchen-intel peterchen-intel added this pull request to the merge queue Aug 20, 2024
Merged via the queue into openvinotoolkit:releases/2024/3 with commit f460a10 Aug 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: llm_bench Label for tool/llm_bench folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants