Clear beam search info when generate() is finished. #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefode
approved these changes
Jul 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| @@ -61,6 +61,7 @@ class ContinuousBatchingPipeline::Impl { | |||
| for (const auto& sequence: request->get_sequences()) { | |||
| m_scheduler->free_sequence(sequence->get_id()); | |||
| } | |||
| m_sampler->clear_beam_search_info(request->get_request_id()); | |||
There was a problem hiding this comment.
I suppose the same should be done for multinomial info? CC @iefode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generate() is launched multiple times
beam_search_infois not cleared and cause failing of sampling.To fix it added clearing of
beam_search_infowhen generate() is finished.