[CI] OV local build #602
[CI] OV local build #602
Conversation
|
@Wovchena I see that CB tests are explicitly run in causal_lm workflow. Is it still required? I suppose after merge CB and stateful, all tests are run on GenAI lib side |
| - name: Download OpenVINO build | ||
| id: openvino_download | ||
| run: | | ||
| wget ${{ env.OV_TARBALL}} --progress=bar:force:noscroll -O openvino_package.tar.gz |
There was a problem hiding this comment.
OV_TARBALL is never set to anything other than ''. This step is always going to fail
There was a problem hiding this comment.
yes, it is needed when you want to use nightly or release package, then just set the link to it here and openvino_build job will be skipped
There was a problem hiding this comment.
Please add this as a code comment.
I noticed you resolved some of the conversations, but they are applicable to other two OS as well
| with: | ||
| name: openvino_package | ||
| path: ${{ env.BUILD_DIR }}/openvino_package.tar.gz | ||
| if-no-files-found: 'error' |
There was a problem hiding this comment.
Why is this step set to if: ${{ always() }} to always run, but at the same time there's if-no-files-found: 'error'. It seems that removing both would give the same result.
There was a problem hiding this comment.
if we remove the always then artifact will not be uploaded in case of any failures in the middle of the job.
Need to keep it as is
There was a problem hiding this comment.
How can an artifact be considered valid if there was an error?
There was a problem hiding this comment.
I didn't say it will be valid) But in case of error between build and upload_artifact steps we would like to save build artifacts anyway
| runs-on: ubuntu-20.04 | ||
| env: | ||
| # A tokenizers' dependency fails to compile with Ninja in CenOS7 env. | ||
| CMAKE_GENERATOR: Unix Makefiles |
There was a problem hiding this comment.
CentOS OV isn't used in your implementation. You can proceed with Ninja
Co-authored-by: Zlobin Vladimir <[email protected]>
Co-authored-by: Zlobin Vladimir <[email protected]>
Co-authored-by: Zlobin Vladimir <[email protected]>
No description provided.