-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support chat conversation for StaticLLMPipeline #580
Merged
Wovchena
merged 12 commits into
openvinotoolkit:master
from
TolyaTalamanov:at/support-chat-model-for-static-llm-pipeline
Jul 17, 2024
Merged
Support chat conversation for StaticLLMPipeline #580
Wovchena
merged 12 commits into
openvinotoolkit:master
from
TolyaTalamanov:at/support-chat-model-for-static-llm-pipeline
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…genai into at/support-chat-model-for-static-llm-pipeline
TolyaTalamanov
force-pushed
the
at/support-chat-model-for-static-llm-pipeline
branch
from
July 5, 2024 08:15
7ba018a
to
670b1d6
Compare
…genai into at/support-chat-model-for-static-llm-pipeline
TolyaTalamanov
commented
Jul 15, 2024
* Adapt for new start_chat(const string&) signature * Handle "ignore_eos" config option
TolyaTalamanov
force-pushed
the
at/support-chat-model-for-static-llm-pipeline
branch
2 times, most recently
from
July 15, 2024 14:21
91a0871
to
20142e2
Compare
TolyaTalamanov
commented
Jul 15, 2024
TolyaTalamanov
force-pushed
the
at/support-chat-model-for-static-llm-pipeline
branch
from
July 15, 2024 14:26
20142e2
to
7d826a3
Compare
slyalin
reviewed
Jul 15, 2024
Wovchena
requested changes
Jul 17, 2024
Wovchena
approved these changes
Jul 17, 2024
pavel-esir
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a typo, but overall looks good. Approved
Co-authored-by: Pavel Esir <[email protected]>
Co-authored-by: Pavel Esir <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 17, 2024
Wovchena
reviewed
Jul 17, 2024
TolyaTalamanov
added a commit
to TolyaTalamanov/openvino.genai
that referenced
this pull request
Jul 22, 2024
# Overview Adding chat mode support for `StaticLLMPipeline`. The current implementation is naive - aggregates the entire chat conversation and pass as new prompt on every new `generate` call. --------- Co-authored-by: Pavel Esir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding chat mode support for
StaticLLMPipeline
.The current implementation is naive - aggregates the entire chat conversation and pass as new prompt on every new
generate
call.