Use get_max_new_tokens() insted of max_new_tokens field when stopping… #1417
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkulakowski
force-pushed
the
mkulakow/max_length
branch
from
402bba1 to
5d527f0
Compare
mzegla
reviewed
Dec 20, 2024
| @@ -105,7 +105,7 @@ class Sampler::GroupBeamSearcher { | |||
| bool done = false; | |||
|
|
|||
| int64_t finish(Beam beam, const ov::genai::GenerationConfig& sampling_params); | |||
| void is_done(const ov::genai::GenerationConfig& sampling_params); | |||
| void is_done(const ov::genai::GenerationConfig& sampling_params, size_t prompt_len); | |||
There was a problem hiding this comment.
I think we can include prompt_len information in Group members during object construction and avoid passing it as a parameter in this method.
ilya-lavrenov
requested changes
Dec 20, 2024
|
One more thing - I believe max_length is now loaded from generation config. Isn't it a model property that is not meant to be a per generation configuration? @michalkulakowski I know you have logic to read that value in OVMS now. Maybe we could move it here and make it a pipeline member. This way it could be used in both OVMS and standalone GenAI app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… generation